Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 5.0 support #249

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Add Django 5.0 support #249

merged 8 commits into from
Jan 2, 2024

Conversation

ckarli
Copy link
Contributor

@ckarli ckarli commented Dec 5, 2023

Django 5.0 Support

Description

Rationale

ckarli and others added 2 commits December 5, 2023 10:56
Django 5.0 Support
commit 0918e15
Author: ckarli <[email protected]>
Date:   Tue Dec 5 10:59:42 2023 +0300

    Django 5.0 Update
@ckarli
Copy link
Contributor Author

ckarli commented Dec 6, 2023

Consolidated the pull requests.

@Andrew-Chen-Wang
Copy link
Collaborator

please also deprecate py 3.7 and include py 3.12. much appreciated

Deprecated Python 3.7 and added Python 3.12
@coveralls
Copy link

coveralls commented Dec 6, 2023

Pull Request Test Coverage Report for Build 7329247929

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.182%

Totals Coverage Status
Change from base Build 6089987763: 0.0%
Covered Lines: 702
Relevant Lines: 715

💛 - Coveralls

@jgillard jgillard mentioned this pull request Dec 13, 2023
@jgillard
Copy link

I see from the last commit that updated Django support, that at least these will need updating also: README.rst, CHANGELOG.rst, docs/quickstart.rst, setup.py, tox.ini. I've never worked on this project, so am not sure what other changes might be required.

2697986

@ckarli
Copy link
Contributor Author

ckarli commented Dec 25, 2023

Updated the files @jgilliard mentioned.

tox.ini Outdated Show resolved Hide resolved
Co-authored-by: Andrew Chen Wang <[email protected]>
@ckarli
Copy link
Contributor Author

ckarli commented Dec 26, 2023

Whops. Typo fixed.

@Andrew-Chen-Wang
Copy link
Collaborator

thanks!

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit f9a9282 into noripyt:master Jan 2, 2024
17 checks passed
@ckarli ckarli deleted the patch-1 branch January 3, 2024 08:15
@Andrew-Chen-Wang Andrew-Chen-Wang changed the title Update requirements.txt Add Django 5.0 support Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants