Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test settings to sdist. Closes #200. #203

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

debdolph
Copy link
Contributor

@debdolph debdolph commented Oct 1, 2021

Description

//: Add test settings to sdist

@debdolph debdolph force-pushed the issue-200 branch 2 times, most recently from 8100b45 to b1b3d8e Compare October 1, 2021 11:44
Copy link
Collaborator

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the original setup.py; I meant please use the package_data kwarg.

@debdolph
Copy link
Contributor Author

debdolph commented Oct 1, 2021

please keep the original setup.py; I meant please use the package_data kwarg.

Then i think it does not work without manifest. Because tox.ini is outside the package.

MANIFEST.in Outdated
@@ -1,2 +1,2 @@
include README.rst LICENSE CHANGELOG.rst requirements.txt
include README.rst LICENSE CHANGELOG.rst requirements.txt tox.ini
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the runtests.py, runtests_urls.py, and settings.py file

@Andrew-Chen-Wang Andrew-Chen-Wang linked an issue Feb 24, 2022 that may be closed by this pull request
@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 8f35039 into noripyt:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please include test settings in sdist
2 participants