Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MDX v1 remark/rehype plugin loading after migration #144

Closed
arcticicestudio opened this issue May 21, 2019 · 0 comments · Fixed by #145
Closed

Fix MDX v1 remark/rehype plugin loading after migration #144

arcticicestudio opened this issue May 21, 2019 · 0 comments · Fixed by #145
Labels
scope-compatibility scope-plugin-support type-bug
Milestone
0.13.0

Comments

@arcticicestudio
Copy link
Contributor

During the migration to MDX 1.0.0 in #137 the now deprecated mdPlugins and hastPlugins options were not replaced with their (new named) respective
equivalents remarkPlugins and rehypePlugins. Even if the documentation states that the options will be removed in v2 and are still supported (only showing a warning in the console when still used), the defined plugins were not loaded anymore causing e.g. no more automatic generation of id attributes for headers in MDX content.

Therefore, to finish 100% of the migration, both options should be renamed.
@arcticicestudio arcticicestudio added this to the 0.13.0 milestone May 21, 2019
@arcticicestudio arcticicestudio self-assigned this May 21, 2019
@arcticicestudio arcticicestudio changed the title Fix MDX remark/rehype plugin loading after 1.0 migration Fix MDX v1 remark/rehype plugin loading after migration May 21, 2019
arcticicestudio added a commit that referenced this issue May 21, 2019
@arcticicestudio
Fix MDX v1 remark/rehype plugin loading after migration
7115056 
During the migration to MDX 1.0.0 (1) in GH-137 the now deprecated (2)
`mdPlugins` and `hastPlugins` options were not replaced with their
(new named) respective equivalents `remarkPlugins` and `rehypePlugins`.
Even if the documentation states that the options will be removed in v2
and are still supported (only showing a warning in the console when
still used), the defined plugins were not loaded anymore causing e.g.
no more automatic generation of `id` attributes for headers in MDX
content.

Therefore, to finish 100% of the migration, both options have been
renamed.

References:
  (1) https://mdxjs.com/blog/v1
  (2) https://mdxjs.com/blog/v1#deprecations

GH-144
@arcticicestudio arcticicestudio mentioned this issue May 21, 2019
Merged
@arcticicestudio arcticicestudio removed their assignment May 21, 2019
@bindlr bindlr mentioned this issue Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope-compatibility scope-plugin-support type-bug
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Fix MDX v1 remark/rehype plugin loading after migration nordtheme/web
1 participant
@arcticicestudio