Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

chcp_beforeInstall event #101

Merged
merged 3 commits into from
Apr 22, 2016
Merged

chcp_beforeInstall event #101

merged 3 commits into from
Apr 22, 2016

Conversation

toostn
Copy link
Contributor

@toostn toostn commented Feb 7, 2016

I've implemented and tested this for iOS. Event is triggered correctly, and I can use it for showing the splash screen as desired in #100.

For Android, maybe the easiest way to fix this is to trigger the event before the InstallationWorker runs?

@nikDemyankov
Copy link
Member

Thanks!
As I said before - Android is implemented in a very similar way, as iOS. So yes, probably just need to dispatch the event either in UpdatesInstaller or InstallationWorker.

@nikDemyankov nikDemyankov added this to the v1.3.0 milestone Feb 8, 2016
@toostn toostn changed the title chcp_beforeInstall event for iOS chcp_beforeInstall event Feb 9, 2016
@toostn
Copy link
Contributor Author

toostn commented Feb 9, 2016

I've added my attempt of an Android implementation. This works well for my use case and doesn't seem to interfere with anything else, but please check it before merging :)

Since I don't know if the EventBus is thread safe, I added the event trigger outside of the InstallationWorker thread, right before the worker is executed. Feel free to move it wherever you see it fits.

@nikDemyankov
Copy link
Member

Awesome, thanks! Seems to be fine. I will merge it in branch dev/v1.3.0, since it's a new feature.

@nikDemyankov
Copy link
Member

Merged in branch dev/v1.3.0 with minor bugfix.

@nikDemyankov nikDemyankov merged commit f484ab8 into nordnet:master Apr 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants