Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updade jest to 24, and update tests #32

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Conversation

polem
Copy link
Contributor

@polem polem commented Mar 26, 2019

Hi, i'd like to use jest 24 with my serverless projet, here is a PR, i updated the test, everything is green :)

@polem
Copy link
Contributor Author

polem commented Apr 2, 2019

Up @artoliukkonen :)

@dhm116
Copy link

dhm116 commented Apr 9, 2019

If you'd like to get to Jest v24 and the latest Serverless, you could try out https://github.com/fireeye/jest-environment-serverless - it's actually able to execute the tests quite a bit faster as well since it's not rerunning Jest separately.

@aaronmcadam
Copy link

This is blocking me from using this project. I need to use Jest 24 because I'm depending on Babel 7.

Here's the error I get:

Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel

If I hack the package.json to bump the Jest version, it fixes it.

@aaronmcadam
Copy link

@polem Were there any reasons why this PR was not merged?

@polem
Copy link
Contributor Author

polem commented Jul 2, 2019

@aaronmcadam no news from the maintener sorry

@aaronmcadam
Copy link

Thanks @polem. That's a shame. Looks like we'll have to use https://www.npmjs.com/package/patch-package

@aaronmcadam
Copy link

I wonder if these plugin repos should be moved to the serverless organisation anyway

@dhm116
Copy link

dhm116 commented Jul 2, 2019

@KariHe KariHe merged commit f98b1e7 into nordcloud:master Nov 18, 2019
@KariHe
Copy link
Contributor

KariHe commented Dec 2, 2019

#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants