[Backport into 5.17] Removing unique
and the unused NAN_SET_BUF_DETACH
#8562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
unique
was removed fromshared_ptr
This PR removes
unique
and the unusedNAN_SET_BUF_DETACH
Signed-off-by: liranmauda [email protected]
(cherry picked from commit 0215f39)
More details in the original PR: #8513
Issues:
npm run rebuild
):Testing Instructions:
npm run rebuild
.Note: original instruction -