Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS - support AWS APIs (NC and containerized) #8538

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Nov 18, 2024

Explain the changes

  1. Adding support to the S3 CORS API: PUT/GET/DELETE
  2. Changing default CORS behavior from a set of defaults to supporting the API following AWS documentation:
    https://docs.aws.amazon.com/AmazonS3/latest/userguide/cors.html
    with some ideas from Azure documentation here: https://learn.microsoft.com/en-us/rest/api/storageservices/cross-origin-resource-sharing--cors--support-for-the-azure-storage-services
  3. Adding an option to create an anonymous bucket policy for read when getting a public-read acl, used by ceph-s3 tests

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. Added a few tests from ceph-tests suite.
  • Doc added/updated
  • Tests added

@nimrod-becker
Copy link
Contributor

I know it's still in draft, but remember to update the table from #8529 once @Neon-White merged it.
It could also be worth adding to bucketspace_s3 since it's a simple proxy in this case.

@jackyalbo jackyalbo force-pushed the jacky_cors branch 7 times, most recently from ab871f4 to 5b9f507 Compare November 24, 2024 16:53
@jackyalbo
Copy link
Contributor Author

I know it's still in draft, but remember to update the table from #8529 once @Neon-White merged it. It could also be worth adding to bucketspace_s3 since it's a simple proxy in this case.

@nimrod-becker, about your second remark, it seems we don't support most of the bucket-level operations in bucketspace_s3 (lifecycle, tagging, encryption, bucket-policy, and so on), so I think we shouldn't add it also in this case, it can be added once we will support bucket-level operations in our APIs in the future (I remember that we wanted to work on it in the past)

@jackyalbo jackyalbo marked this pull request as ready for review November 24, 2024 17:23
@nimrod-becker
Copy link
Contributor

We can, we can either do it all together or add this one,

@jackyalbo jackyalbo force-pushed the jacky_cors branch 2 times, most recently from a301426 to 1cb7b14 Compare November 27, 2024 15:50
Signed-off-by: jackyalbo <[email protected]>
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackyalbo jackyalbo changed the title CORS - initial support - containerized CORS - support AWS APIs (NC and containerized) Nov 27, 2024
@jackyalbo jackyalbo merged commit 9bce005 into noobaa:master Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants