Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 修复依赖注入默认值参数在 __eq__ 被重写时报错的问题 #971

Merged
merged 1 commit into from
May 14, 2022

Conversation

yanyongyu
Copy link
Member

No description provided.

Unverified

This user has not yet uploaded their public signing key.
@yanyongyu yanyongyu added the bug Something isn't working label May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #971 (5f9ad33) into master (42a49a2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files          42       42           
  Lines        3096     3096           
=======================================
  Hits         2393     2393           
  Misses        703      703           
Flag Coverage Δ
unittests 77.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/dependencies/__init__.py 88.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a49a2...5f9ad33. Read the comment docs.

@yanyongyu yanyongyu changed the title Fix: di default param eq override Fix: 修复依赖注入默认值参数在 __eq__ 被重写时报错的问题 May 14, 2022
@github-actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-971--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 14, 2022 08:32 Inactive
@yanyongyu yanyongyu merged commit 5e970a2 into master May 14, 2022
@yanyongyu yanyongyu deleted the fix/di-default-param branch May 14, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

1 participant