Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 补充依赖注入部分情况下类型错误时的日志提示 #2343

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

A-kirami
Copy link
Contributor

@A-kirami A-kirami commented Sep 4, 2023

No description provided.

@A-kirami A-kirami changed the title 🐛 修复部分情况下依赖注入类型错误时缺少日志的问题 Fix: 修复部分情况下依赖注入类型错误时缺少日志的问题 Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2343 (f411f4a) into master (8057787) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2343   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          46       46           
  Lines        3379     3379           
=======================================
  Hits         3059     3059           
  Misses        320      320           
Flag Coverage Δ
unittests 90.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nonebot/dependencies/__init__.py 96.77% <100.00%> (ø)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

🚀 Deployed on https://deploy-preview-2343--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 11:44 Inactive
@yanyongyu yanyongyu added the enhancement New feature or request label Sep 4, 2023
@yanyongyu yanyongyu changed the title Fix: 修复部分情况下依赖注入类型错误时缺少日志的问题 Feature: 补充依赖注入部分情况下类型错误时的日志提示 Sep 4, 2023
@yanyongyu yanyongyu merged commit 81cb356 into nonebot:master Sep 4, 2023
@A-kirami A-kirami deleted the fix/skipped-trace branch September 4, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants