Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: 完成发布插件教程 #2078

Merged
merged 14 commits into from
Jun 11, 2023
Merged

Docs: 完成发布插件教程 #2078

merged 14 commits into from
Jun 11, 2023

Conversation

NCBM
Copy link
Contributor

@NCBM NCBM commented Jun 2, 2023

完成发布插件教程

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-2078--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 2, 2023 16:55 Inactive
@yanyongyu yanyongyu added the documentation Improvements or additions to documentation label Jun 3, 2023
@github-actions github-actions bot temporarily deployed to pull request June 3, 2023 14:48 Inactive
@NCBM NCBM requested review from Well2333 and yanyongyu June 3, 2023 14:54
@NCBM
Copy link
Contributor Author

NCBM commented Jun 3, 2023

是否需要在当前 PR 中更新“插件信息”章节？

Well2333
Well2333 previously approved these changes Jun 3, 2023
View reviewed changes
@Well2333
Copy link
Contributor

Well2333 commented Jun 3, 2023

是否需要在当前 PR 中更新“插件信息”章节？

我觉得可以单开个PR

@github-actions github-actions bot temporarily deployed to pull request June 3, 2023 17:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 3, 2023 17:48 Inactive
@NCBM NCBM requested a review from Well2333 June 3, 2023 17:51
yanyongyu
yanyongyu reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大概看了下主要几个问题：

  1. 应该以开发者第一人称描述文档，如使用“我们”
  2. 全部以 NoneBot 指代 NoneBot2
  3. 文档描述的语句读上去还是有点别扭或者有点单调，不够丰富（

website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
website/docs/developer/plugin-publishing.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 5, 2023 03:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2023 04:13 Inactive
@NCBM NCBM requested a review from yanyongyu June 5, 2023 04:13
@github-actions github-actions bot temporarily deployed to pull request June 5, 2023 04:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2023 04:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2023 04:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 9, 2023 16:26 Inactive
@NCBM NCBM requested a review from he0119 June 11, 2023 13:52
@github-actions github-actions bot temporarily deployed to pull request June 11, 2023 13:53 Inactive
he0119
he0119 previously approved these changes Jun 11, 2023
View reviewed changes
@github-actions github-actions bot temporarily deployed to pull request June 11, 2023 15:36 Inactive
@yanyongyu yanyongyu merged commit cb8d48c into nonebot:master Jun 11, 2023
@NCBM NCBM deleted the patch-docs-1 branch June 12, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanyongyu yanyongyu yanyongyu approved these changes

@he0119 he0119 he0119 left review comments

@Well2333 Well2333 Awaiting requested review from Well2333

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NCBM @Well2333 @he0119 @yanyongyu