Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 重构驱动器 lifespan 方法 #1860

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

yanyongyu
Copy link
Member

@yanyongyu yanyongyu commented Mar 29, 2023

lifespan 将顺序执行所有操作,不再并行。

fastapi deprecated on_event

@yanyongyu yanyongyu added the enhancement New feature or request label Mar 29, 2023
StarHeartHunt
StarHeartHunt previously approved these changes Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1860 (3555e1e) into master (0d0bc65) will increase coverage by 0.21%.
The diff coverage is 77.58%.

@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
+ Coverage   88.21%   88.42%   +0.21%     
==========================================
  Files          44       45       +1     
  Lines        3182     3215      +33     
==========================================
+ Hits         2807     2843      +36     
+ Misses        375      372       -3     
Flag Coverage Δ
unittests 88.42% <77.58%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/drivers/aiohttp.py 61.79% <ø> (ø)
nonebot/drivers/httpx.py 91.66% <ø> (ø)
nonebot/drivers/quart.py 90.07% <ø> (ø)
nonebot/drivers/websockets.py 68.75% <ø> (ø)
nonebot/drivers/none.py 41.11% <28.57%> (+0.48%) ⬆️
nonebot/drivers/fastapi.py 89.24% <84.61%> (+0.57%) ⬆️
nonebot/drivers/_lifespan.py 96.77% <96.77%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

🚀 Deployed on https://deploy-preview-1860--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 29, 2023 07:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 29, 2023 07:34 Inactive
@yanyongyu yanyongyu merged commit a8a7639 into master Mar 29, 2023
@yanyongyu yanyongyu deleted the feat/improve-lifespan branch March 29, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants