Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 新增 dotenv 嵌套配置项支持 #1324

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

yanyongyu
Copy link
Member

dependency pydantic is updated to ^1.10.0

@yanyongyu yanyongyu added the enhancement New feature or request label Oct 13, 2022
@yanyongyu yanyongyu requested a review from he0119 October 13, 2022 04:26
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1324 (74a52e5) into master (9619477) will decrease coverage by 0.08%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
- Coverage   86.00%   85.91%   -0.09%     
==========================================
  Files          41       41              
  Lines        3215     3230      +15     
==========================================
+ Hits         2765     2775      +10     
- Misses        450      455       +5     
Flag Coverage Δ
unittests 85.91% <90.69%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/config.py 94.79% <89.74%> (-5.21%) ⬇️
nonebot/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

🚀 Deployed on https://deploy-preview-1324--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 13, 2022 04:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 13, 2022 04:46 Inactive
Copy link
Member

@he0119 he0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试的名字我真想不到什么好的(

nonebot/config.py Outdated Show resolved Hide resolved
tests/.env.test Show resolved Hide resolved
tests/test_init.py Show resolved Hide resolved
Co-authored-by: hemengyang <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 13, 2022 16:30 Inactive
@yanyongyu yanyongyu merged commit db534b8 into master Oct 14, 2022
@yanyongyu yanyongyu deleted the feat/nested-config branch October 14, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants