Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 添加 State 响应器触发消息注入 #1315

Merged
merged 10 commits into from
Oct 12, 2022

Conversation

A-kirami
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2022

🚀 Deployed on https://deploy-preview-1315--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 10, 2022 14:11 Inactive
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1315 (82db00f) into master (ab227ee) will increase coverage by 0.11%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   85.88%   86.00%   +0.11%     
==========================================
  Files          41       41              
  Lines        3174     3215      +41     
==========================================
+ Hits         2726     2765      +39     
- Misses        448      450       +2     
Flag Coverage Δ
unittests 86.00% <95.91%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/rule.py 97.76% <92.00%> (-0.65%) ⬇️
nonebot/consts.py 100.00% <100.00%> (ø)
nonebot/params.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在state里不能用一个key,会出现覆盖的情况,比如rule为startswith("xxx") & endswith("xxx")

@A-kirami
Copy link
Contributor Author

在state里不能用一个key,会出现覆盖的情况,比如rule为startswith("xxx") & endswith("xxx")

忘了这种情况,那还是分别设置key比较好

@A-kirami A-kirami marked this pull request as draft October 10, 2022 15:06
@github-actions github-actions bot temporarily deployed to pull request October 11, 2022 10:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2022 10:37 Inactive
@A-kirami A-kirami marked this pull request as ready for review October 11, 2022 10:38
nonebot/rule.py Outdated Show resolved Hide resolved
nonebot/rule.py Outdated Show resolved Hide resolved
nonebot/rule.py Outdated Show resolved Hide resolved
nonebot/rule.py Outdated Show resolved Hide resolved
tests/test_rule.py Outdated Show resolved Hide resolved
tests/test_rule.py Outdated Show resolved Hide resolved
tests/test_rule.py Outdated Show resolved Hide resolved
@yanyongyu yanyongyu added the enhancement New feature or request label Oct 11, 2022
@github-actions github-actions bot temporarily deployed to pull request October 11, 2022 11:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2022 12:31 Inactive
@A-kirami A-kirami requested a review from yanyongyu October 11, 2022 12:37
@yanyongyu yanyongyu changed the title Feature: 添加 State 响应器触发消息 Feature: 添加 State 响应器触发消息注入 Oct 12, 2022
@yanyongyu yanyongyu merged commit 8377680 into nonebot:master Oct 12, 2022
@A-kirami A-kirami deleted the feta/trigger branch October 12, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants