Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bypass body serialization if body type is data #9

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

albertocsouto
Copy link

@albertocsouto albertocsouto commented Sep 29, 2023

  • Added support to indicate other content types in request body different than json

Note, my branch is taken from tag 1.0.0

Resolves #10

@albertocsouto albertocsouto force-pushed the feat/custom-media-support branch from 9913017 to f7cad49 Compare October 2, 2023 07:02
@albertocsouto albertocsouto changed the title feat: added custom media support feat: bypass body serialization if body type is data Oct 2, 2023
@KeatoonMask
Copy link
Collaborator

Hi @albertocsouto

we are not working on this repo more. We continued this project in the Inditex repo, see attached link. Are you still using this for any internal project or so? I'm not sure what to do with nclient right now, should we close it or maintain it?

https://github.com/inditex/mlb-httpclientios

Copy link
Collaborator

@KeatoonMask KeatoonMask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of changes look good to me!

Sources/NClient/Endpoint.swift Outdated Show resolved Hide resolved
@albertocsouto albertocsouto changed the base branch from main to release/1.0.0 October 3, 2023 21:14
@KeatoonMask KeatoonMask merged commit 9c6dde6 into release/1.0.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support raw data in HTTP Body (for mp4 for example)
2 participants