Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types of swiper-effect-utils.d.ts #7655

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix types of swiper-effect-utils.d.ts #7655

merged 1 commit into from
Jul 31, 2024

Conversation

kudohamu
Copy link
Contributor

This PR fix two type issues of swiper-effect-utils.d.ts.

1. change import of .d.ts file to import type

related: 30ce8e0

A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file './types/index.ts' instead?

fix_types_of_effect_utils_01

2. Fix invalid optional parameter declaration of createShadow.

In making this correction, I checked that suffix parameter is specified at all places in this repo where createShadow is called.

A required parameter cannot follow an optional parameter.

fix_types_of_effect_utils_02

@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented Jul 29, 2024

Task nolimits4web/SWIPER-149 was created

t0ggles task SWIPER-149

@t0ggles t0ggles bot added the t0ggles Linked to the t0ggles task label Jul 29, 2024
@nolimits4web nolimits4web merged commit 4875f26 into nolimits4web:master Jul 31, 2024
Copy link

t0ggles bot commented Jul 31, 2024

Task nolimits4web/SWIPER-149 status changed to Done

@nolimits4web
Copy link
Owner

Merged, thanks!

@kudohamu kudohamu deleted the fix-types-of-effect-utils branch August 1, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t0ggles Linked to the t0ggles task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants