Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix react components props type #7000

Closed
wants to merge 1 commit into from

Conversation

d4v1d82
Copy link

@d4v1d82 d4v1d82 commented Aug 30, 2023

This PR fix an issue with typescript react components props definitions.
In the original definition both SwiperProps and SwiperSlideProps are defined 2 times generating issue during the type check process.

@arodik
Copy link

arodik commented Sep 1, 2023

Hi, @d4v1d82 . Which TS version do you use? Looks like I have a similar problem, but your approach doesn't help me by some reason.
I created an alternative fix that works for my case.
#7004

Probably makes sense to merge them both 😄

@d4v1d82
Copy link
Author

d4v1d82 commented Sep 1, 2023

Hi @arodik, I'm on typescript v4.9.5.
My fix worked on my project and I don't think I've issue with importing from index.
Btw.. yes, the types have some issue right now :P

@arodik
Copy link

arodik commented Sep 1, 2023

TS v5 fixes all these bugs btw, I suggest you to upgrade if you can 😅

@nolimits4web
Copy link
Owner

Thank you, had to merge manually as there is some not needed extra in your file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants