Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): set isElement on swiper-containers only #6870

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

stefanholzapfel
Copy link
Contributor

Hi @nolimits4web!

I think you introduced a subtle bug with the swiper web component.

In the core you expect the swiper to be a swiper webcomponent whenever it's parentNode has a host, but you forget that the swiper might be a direct child to another (non-swiper) webcomponent.

When that is the case (which happened to me), you assign this other web-component as "slidesEl" to the swiper object.

I noticed that when using the manipulation module's "appendChild" method which now assigned new slides as children to my own web-component.

I suggest to add another condition to the isElement check (see commit).

@nolimits4web nolimits4web merged commit 2f61fda into nolimits4web:master Jul 25, 2023
@nolimits4web
Copy link
Owner

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants