Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixed __proto__ pollution #4692

Closed

Conversation

hydRAnger
Copy link

@lobosan
Copy link

lobosan commented Jun 21, 2021

Does this also need to check for constructor and prototype like this?
https://github.com/ionic-team/ionic-framework/pull/23344/files

@nolimits4web
Copy link
Owner

I am afraid that will required a more work and not extend 'proto', 'constructor', 'prototype' props. Plus it needs correctly reference other Swiper instances (required for Thumbs and Controller to work correctly). To be honest last Swiper v5 was released almost a year ago, and I didn't plan new v5 releases for sure. Why just not copy v5 package locally and do the local changes instead?

@lobosan
Copy link

lobosan commented Jun 22, 2021

@nolimits4web @hydRAnger I thought the one-line code was the fix in version 6 and it seems it would work for v5. Is it possible to deploy a new v5 with this change?

@hydRAnger
Copy link
Author

@nolimits4web @hydRAnger I thought the one-line code was the fix in version 6 and it seems it would work for v5. Is it possible to deploy a new v5 with this change?

according to your suggestion, what should I do for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants