Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bi-link): isRelativePath invalid in vuepress #361

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

LincZero
Copy link
Contributor

@LincZero LincZero commented Dec 1, 2024

No description provided.

@LincZero LincZero changed the title fix(bi-link): isRelativePath invalid in windows fix(bi-link): isRelativePath invalid in vuepress Dec 6, 2024
@nekomeowww
Copy link
Member

Rebase / Merge is required.

Copy link

github-actions bot commented Dec 7, 2024

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://6763b5f7e6938314d3bdc569--nolebase-integrations.netlify.app
Windows Success https://6763b6045b43c217fbe8d787--nolebase-integrations.netlify.app

@LincZero LincZero requested a review from nekomeowww December 18, 2024 00:03
@nekomeowww
Copy link
Member

As suggested in #361 (comment)

We should write the comments to tell the later coming developers why these properties, and perhaps we can file up an issue to VitePress to ask them whether this is the unexpected behavior.

Or at least, link this PR in the comment.

@nekomeowww nekomeowww enabled auto-merge (squash) December 19, 2024 10:40
@nekomeowww nekomeowww merged commit ba528f1 into nolebase:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants