Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give names to asyncio tasks in Python 3.8+ #542

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

nolar
Copy link
Owner

@nolar nolar commented Sep 10, 2020

What do these changes do?

Expose the name/purpose of the asyncio tasks in tests and at runtime in case of failures. Previously, they were anonymous "Task-25" and alike.

Description

For Python 3.7, keep the tasks unnamed (it does not support named tasks):

Issues

#338

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar nolar added enhancement New feature or request automation CI/CD: testing, linting, releasing automatically labels Sep 10, 2020
@nolar nolar force-pushed the named-asyncio-tasks branch 3 times, most recently from 3f9c60b to 8c44e11 Compare September 10, 2020 22:26
@nolar nolar force-pushed the named-asyncio-tasks branch from 8c44e11 to d8d5664 Compare September 10, 2020 22:36
@nolar nolar merged commit 8102384 into master Sep 10, 2020
@nolar nolar deleted the named-asyncio-tasks branch September 10, 2020 22:41
@nolar nolar linked an issue Sep 12, 2020 that may be closed by this pull request
9 tasks
@nolar nolar removed a link to an issue Sep 12, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD: testing, linting, releasing automatically enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant