Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double the timing expectations for the queue batching tests #528

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

nolar
Copy link
Owner

@nolar nolar commented Sep 2, 2020

What do these changes do?

Double the timing expectations for the queue-batching tests.

Description

Previously, before #522, the timing allowances were very broad, so the tests passed even if the number of "batching" attempts (and, therefore, timing) were different from expected.

Now, the timing allowances are dynamically & statistically calculated in the environment where it runs, with different overhead for the non-timed code. As a result, the timing allowances for the tests were narrowed to the strictly expected timing of each "batching" cycle plus overhead. As a result, the number of times this "baching" is performed started to matter.

In the queue batching test, there are 2 batches actually expected: one for a batch of events, another one for the EOS token when the watcher finishes. The tests were expecting only 1.

Now, they will expected 2.

This only fixes the CI pipeline and does not affect the users.

Issues/PRs

Issues: #212 #338

Related: a follow-up for #522.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Mostly CI/CD automation, contribution experience

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar nolar added bug Something isn't working automation CI/CD: testing, linting, releasing automatically labels Sep 2, 2020
@nolar nolar merged commit 064d946 into master Sep 2, 2020
@nolar nolar deleted the fix-timing-of-queue-batching-tests branch September 2, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant