Introduce config param to control interface naming scheme #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
force-pushed
the
configure_naming
branch
from
9f5f457 to
8d7b85a
Compare
Levovar
force-pushed
the
configure_naming
branch
from
8d7b85a to
869028e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #78 the meaning of the container_prefix was changed to what it always should have been; while also making the life of netadmins easier.
As it turns out DANM is already considered legacy by some TelCo applications, who expressed dissatisfaction by this indeed backward incompatible change :)
So, we have made this functionality configurable. The default naming scheme is the new one though, so if you are new to DANM, you don't need to configure anything for a flexible naming scheme.
For those of you who think something called prefix should mean an exact name :), this behaviour now can be set via the newly introduced config flag called "namingScheme".
We made a decision that all config param shall come from DANM's CNI config file. To adhere to this rule, existing config flag CNI config dir was also transformed to this format from being an env variable.