100% cnidel UT coverage #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
force-pushed
the
cnidel_uts
branch
10 times, most recently
from
c55bc0f to
0fe5b5c
Compare
…etworkType parameter against a constant string. Added easy TCs for two auxiliary cnidel public functions. Setup related delegate test framework created, with the first negative TC.
…ration check as well. Empty fakeipam configs are considered erroneous from this day onward. Reason is that the presence of the "IPAM" field is mandatory according to the CNI spec, and most CNIs can't deal with "none" type IP allocations. Most CNIs are not DANM ;) Added TC to test this newly introduced error case.
Created skeleton CNI plugin to be able to test the different delegated config files coming out of cnidel package. First TC testing static, file-based configuration via Flannel is added to showcase how to use the test tool. UTs were modified to run in container to avoid trashing the executor's home environment.
Added some extra test cases to cover CNI result conversion code. It turns out it was faulty, and we were not handling default returned 0.3.1 result well. Code is corrected, bot 020, and current Results are properly managed now.
Also started checking that the relevant CNI delegation specific environment variables are set to the right value. Added additional testcases to check 0.2.0 version conversion and parsing works both with IPv4, and IPv6 addresses.
Test environment is mocked by re-using the SR-IOV CNI project's awesome environment setup method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, really.
Following bugs were corrected during testing (running list):
The following functionalities were changed during the review:
3rd-party CNIs are not equipped to handle this scenario (looking at you macvlan), so it is better to fail the interface creation already in DANM.
Not everyone can be TelCo ready :) As Intel's SR-IOV CNI supports L2 mode, it was exempt above this rule