Spring cleaning: pkg directory cleaned-up according to convention #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…renamed to metacni, and thus become testable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pkg directory literally became a dumping ground over time for Golang code.
According to the Golang project layout convention, pkg shall only contain code, which could be re-used by others. So, it was time for a grand spring cleanup!
Stubs and unit tests were moved under test/.
Crd was moved one level higher.
Glide files were moved one level higher.
Main packages of the binaries have moved under cmd/.
This changes enables the proper unit testing, and coverage measurement of functional code which was previously bundled-up in main packages!