Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of buildah+podman when building danm #38

Merged
merged 12 commits into from
Jan 22, 2019
Merged

Conversation

janosi
Copy link
Contributor

@janosi janosi commented Jan 9, 2019

What type of PR is this?
feature

What does this PR give to us:
Supporting buildah and podman based build of danm.

Which issue(s) this PR fixes (in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #37

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

@Levovar
Copy link
Collaborator

Levovar commented Jan 10, 2019

is it possible to configure Travis to test both building methods?

@janosi
Copy link
Contributor Author

janosi commented Jan 19, 2019

Now docker and buildah based builds are tested parallel in Travis. It was a great adventure :)

@Levovar Levovar merged commit c26c8d2 into nokia:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildah/podman support in danm build procedure
2 participants