Restrict post-processing to kernel network interfaces #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen that IPv6 is disabled on the parent interface level in some edge cases (can be debated who does this nowadays, but, well). In this rare scenario explicitly setting either disable, or enable IPv6 setting into the interface specific sys path fails, as the whole tree will not exist. Adding stat check to both sysctl checker functions solves the issue.
…erfaces The problem corrected in the first commit was just one symptom of ungraceful handling of user space interfaces. The real, and generic correction is delivered by this commit. Post-processing in general is now skipped for links not managed by the kernel. A warning message is also written when this happens, so post-mortem debugging for kernel managed links is still possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the post-processing done by DANM is restructured to accomodate CNIs which do not create kernel networking interfaces.
Userpsace CNIs, or various network config CNIs all belong to this category. When such a CNI is invoked through DANM, various post-processing errors related to automatically setting certain interface specific configs (v/, DAD, IP routes etc.) in the kernel would fail simply because the interface does not exist.
These issues are universally solved by checking for the presence of a kernel interface first, and only initiating post-processing if one is found.