Add Pod UID and Nodename parameters to svcwatcher created EndPoints #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to be inline with how K8s in-built Service controller creates its own EPs. Not doing so might break assumptions hard-coded into external DNS Controllers, such as CoreDNS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #203
This is needed to be inline with how K8s in-built Service controller creates its own EPs.
Not doing so might break assumptions hard-coded into external DNS Controllers, such as CoreDNS.
Svcwatcher created EndpointAddresses after the modification for a StatefulSet managed Pod:
ip: 10.240.1.104
nodeName: 172.31.3.157
targetRef:
kind: pod
name: internal-processor-set-4
namespace: default
resourceVersion: "12491055"
uid: a20958ed-9196-433d-a75d-e3200f233f8d