Increase resiliency of critical execution paths against temporary, or permanent network outages #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd permanent outages New API added to DanmNet to free IPs in the same scoe s deleting a DanmEp This should solve the problem of DanmEps ever disappearing without clearing Dangling resources can still happen, but user now has a chance to clean them up manually, or leave it to Cleaner utility
This was referenced Mar 6, 2020
This was
linked to
issues
Mar 9, 2020
…a RAII manner This is now universally happening during both IPVLAN, and delegated operations. The result is a vastly simplified execution path greatly decreasing the chances of IPs getting leaked inthe future.
Levovar
changed the title
…tored DanmEp creation Changing to DanmEp based read from interface based works for both default, and normal networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Umbrella ticket to fully solve #166 and #165, and partially #167.
In the new structure DanmEps will never be cleaned when its related IPs could not be freed in the network for any reason. In these scenarios it will become either user, or Cleaner's responsibility to handle the dangling resources.