Adding V6 support to svcwatcher, plus fixing concurrent updates #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
force-pushed
the
svcw_update_fix
branch
2 times, most recently
from
817c6a5 to
85419fa
Compare
Also adding solution to handle conflicting endpoint update scenarios. Correction is not the elegant one, but should work with the current architectural constraints. We will infinitely re-try EndPoint update in case of conflict, but only retry for 1 sec in case of temporary network outages etc.
Levovar
force-pushed
the
svcw_update_fix
branch
from
85419fa to
d45eb55
Compare
…failure during creation Needed to rework concurrent update handling, because it is not enough to retry the operation, we also need to reapply the changes to the new EP structure. In every block where EP is updated. Lastly, found a random core in the new DeleteDanmEp API.
Levovar
force-pushed
the
svcw_update_fix
branch
from
d45eb55 to
8137c85
Compare
|
ok, so to record for the next generation: I ended up adding an extremely ugly concurrency handling block to all EndPoint update part other than that, performance bottlenecks can happen if the same EndPoint in the same service needs to be conccurently updated, e.g. you create 100 Pods at the same time, matching the exact same Service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DANM svcwatcher managed EndPoints now support IPv6 addresses as well!
also correcting #185
Correction is not the elegant one, but should work with the current architectural constraints.
We will infinitely re-try EndPoint update in case of conflict, but only retry for 1 sec in case of temporary network outages etc.