Set verbosity level on info/debug messages to reduce unnecessary logging #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah replacement can be done later, sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
What does this PR give to us:
Currently svcwatcher is very noisy. It generates too many log entries, because all the function calls are logged. This PR sets the verbosity level of these info/debug messages to 5, so they will be suppressed by default. Such detailed logging can be enabled by
-v=5commandline parameter.Which issue(s) this PR fixes
Fixes #14
Special notes for your reviewer:
I know that you have plans to replace glog to something better, but this fix is kindof urgent to reduce fluentd load and save log data store capacity.
Does this PR introduce a user-facing change?:
NONE