Various CNI delegation corrections related to framework bump, and central IPAM support #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug is corrected both in cnidel, and metacni package related to Free-ing IPs when an error happened during the execution of the same asynch thread. The correction is to immediately refresh the network manifest after allocation to avoid working on an out-of-date local copy. CNI version support is now explicitly set to 0.3.1 to avoid any accidental mis-translation. Started correctly filling IPAM config for static CNI deletes when DANM was reserving their IP during setup.
Levovar
force-pushed
the
central_ipam_fixes
branch
2 times, most recently
from
01cb1de to
37dd874
Compare
Added Update counter checks to the cnidel / setup TCs. These extra assertation now cover the cases related to the IP leaking bug.
Levovar
force-pushed
the
central_ipam_fixes
branch
from
37dd874 to
ec5450f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug is corrected both in cnidel, and metacni package related to Free-ing IPs when an error happened during the execution of the same asynch thread.
The correction is to immediately refresh the network manifest after allocation to avoid working on an out-of-date local copy.
This bug is probably present from earlier, accidentally caught during testing.
CNI version support is now explicitly set to 0.3.1 to avoid any accidental mistranslation of CNI results.
Started correctly filling IPAM config for static CNI deletes when DANM was reserving their IP during setup.
DANM CNI log file can be found under /ar/log/danm.log from now on!