Netwatcher got new handlers for "Update" events #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
force-pushed
the
netwatcher_modify
branch
from
c2c62e8 to
5cd9046
Compare
Whenever a network management API is updated in the API server, netwatcher will handle that event from now on. It will take care of deleting the old, and creating the new interfaces on the host. We only re-create the interfaces if something really changed: either VNI, or host_device. We also stop the futile attempts of provisioning host interfaces for networks not needing them, such as SR-IOV networks.
Levovar
force-pushed
the
netwatcher_modify
branch
from
5cd9046 to
44b3b3e
Compare
…of networks which would result in invalid cluster state.
Levovar
force-pushed
the
netwatcher_modify
branch
from
26a2980 to
42b871e
Compare
Added checks for namespace when deciding if a Pod is connected to the network. For TNs and DNs the EP needs to be in the same namespace as the network to consider it "connected". For CNs name match is enough, as it is a non-namespaced API.
Levovar
force-pushed
the
netwatcher_modify
branch
from
093c16c to
8efef19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a network management API is updated in the API server, netwatcher will handle that event from now on.
It will take care of deleting the old, and creating the new VLAN/VxLAN interfaces on the host.
In the scope of this PR rejecting modify events (update/delete) when the update could possibly break the system is also implemented.
For example we shall not allow modifications going through which would delete an interface still being used by running Pods, and shall not allow modifications leaving dangling host interfaces behind.
Following the same logic we also forbid network deletion if there are any Pods out there connecting to it.
Solves use-case 5 from #23