UTs for admit/netadmit #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We separately test each and every rule with all 3 APIs. This might make the UT file seem superflous, but it is required for complete requirement coverage.
…reg allocation pool, and TNet API.
All existing admit UTs were refactored to validate the number of expected patches is exactly matching with the received. In addition, we also check that exaclty & only those JSON document paths are being patched what we expect. Added some TCs to check the various mutation cases for non-TN networks.
…d Tenantconfig special scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And with this review we cover the the whole 4.0 functionality!
Better late than never ;)