Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "none" IP allocation scheme for SR-IOV interfaces #110

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

Levovar
Copy link
Collaborator

@Levovar Levovar commented Jul 16, 2019

Fixes #107

When no IPs were allocated by IPAM module we don't include anything into the "ipam" section of the SR-IOV delegate. This will result in the CNI skipping IP allocation, rather than invoking fakeipam with an empty request.

…tionary if there is no IP to pass to fakeipam.

The inclusion of the empty dict caused "none" type IP allocation to misbehave.
@Levovar Levovar merged commit 21125b7 into master Jul 16, 2019
@Levovar Levovar deleted the fix_none_ip branch July 16, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None type IP allocation fails for allowed delegates
1 participant