UTs for newly introduced confman package #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
force-pushed
the
netdel_ut
branch
2 times, most recently
from
cc59502 to
a127709
Compare
Refactoring is -again- needed to be able to test the new changes: - for easy future extension stub instantiation now takes one struct called TestArtifacts - webhook function are refactored to use a pre-created DANM client as a member of a struct, rather than everyone using their own The original approach was impossible to stub, the new -hopefully- won't run into race conditions
- there was a missing return in Webhook main loop when K8s client could not be created - updated TenantNetwork schema descriptor to explicitly mention interface name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started adding UTs for new 4.0 confman package.
Refactoring is -again- needed to be able to test the new changes:
The original approach was unstubbable, the new -hopefully- won't run into race conditions