Ungradlefy the Groovy DSL mixin of public types #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacasseio
force-pushed
the
lacasseio/breakdown/ungradlefy-groovy-dsl-mixin
branch
from
e4ba997 to
303a899
Compare
As we are moving away from dynamic instantiation, we need to manually mixin the Groovy DSL methods inside the public types. It can be perceived as unecessary or going against idiomatic Gradle but is in fact much better this way as IDEs will have better auto-complete as well as eliminating a whole class of errors because of the dynamic instantiation.
lacasseio
force-pushed
the
lacasseio/breakdown/ungradlefy-groovy-dsl-mixin
branch
from
303a899 to
f6c4b21
Compare
lacasseio
deleted the
lacasseio/breakdown/ungradlefy-groovy-dsl-mixin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are moving away from dynamic instantiation, we need to manually
mixin the Groovy DSL methods inside the public types. It can be
perceived as unecessary or going against idiomatic Gradle but is in fact
much better this way as IDEs will have better auto-complete as well as
eliminating a whole class of errors because of the dynamic
instantiation.