Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: performance improvement for large jobs #38

Merged
merged 10 commits into from
Nov 5, 2024
Merged

feat: performance improvement for large jobs #38

merged 10 commits into from
Nov 5, 2024

Conversation

niyiyu
Copy link
Contributor

@niyiyu niyiyu commented Nov 4, 2024

  • Allow FDSN channel catalog to query channel metadata and cached locally. Faster than XML channel catalog when running locally, but should be careful not being banned by FDSN service.
  • Improve PNWstore query efficiency, especially using LIKE statement in SQLite
  • All data query limited to ?H? and ?N? channel, which is a reasonable choice in most case.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 58.78%. Comparing base (dc30ff6) to head (a31f3e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/noisepy/seis/io/pnwstore.py 0.00% 13 Missing ⚠️
src/noisepy/seis/io/channelcatalog.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   58.11%   58.78%   +0.67%     
==========================================
  Files          16       16              
  Lines        2077     2089      +12     
==========================================
+ Hits         1207     1228      +21     
+ Misses        870      861       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyiyu niyiyu marked this pull request as ready for review November 5, 2024 01:37
@niyiyu niyiyu merged commit 7811873 into main Nov 5, 2024
7 checks passed
@niyiyu niyiyu deleted the niyiyu/update branch November 5, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant