Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read station list from a file #174

Closed
carlosgjs opened this issue Aug 10, 2023 · 0 comments · Fixed by #269
Closed

Read station list from a file #174

carlosgjs opened this issue Aug 10, 2023 · 0 comments · Fixed by #269
Assignees
@IshikaKhandelwal
Labels
enhancement New feature or request

Comments

@carlosgjs
Copy link
Collaborator

Today the station list can be specified in the config.yaml file. However, in certain scenarios the list can be very long (1000s), so it would be useful to load this list from an external file (e.g. stations.txt).

This task consists of updating the ConfigParameters class (`src/noisepy/seis/datatypes.py):

  1. Add a stations_file field that is validated to be a valid file path
  2. Validate that if stations_file is set, stations is empty
  3. If stations_file is set:
    • When loading, load the list from the file and into the stations field
    • When saving, save the list to the file and set the stations field to none
  4. Add unit tests for this new behavior
@carlosgjs carlosgjs added the enhancement New feature or request label Aug 10, 2023
@carlosgjs carlosgjs mentioned this issue Aug 10, 2023
Open
IshikaKhandelwal added a commit to IshikaKhandelwal/NoisePy that referenced this issue Nov 21, 2023
@IshikaKhandelwal
Fixed issue noisepy#174
923f74c
IshikaKhandelwal added a commit to IshikaKhandelwal/NoisePy that referenced this issue Nov 30, 2023
@IshikaKhandelwal
Fixed issue noisepy#174 - Read station list from a file
48294a4
IshikaKhandelwal added a commit that referenced this issue Nov 30, 2023
@IshikaKhandelwal
Fixed Issue #174
b080dc2
@IshikaKhandelwal IshikaKhandelwal mentioned this issue Nov 30, 2023
Merged
IshikaKhandelwal added a commit that referenced this issue Dec 4, 2023
@IshikaKhandelwal
feat: Read station list from a file (#269)
ae6a574 
* Fixed Issue #174

* Incorporating the helper functions

* Adding TODO

* Adding TODO
kuanfufeng pushed a commit that referenced this issue Jan 24, 2024
@IshikaKhandelwal
feat: Read station list from a file (#269)
380d04e 
* Fixed Issue #174

* Incorporating the helper functions

* Adding TODO

* Adding TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IshikaKhandelwal IshikaKhandelwal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Read station list from a file noisepy/NoisePy
2 participants
@carlosgjs @IshikaKhandelwal