Release 1.1 #8
Merged
Release 1.1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
April 8, 2018 23:11
Checks don't do anything yet aside from displaying warnings.
switch = more adaptable for later + this code was making me annoyed.
reformatting. (main.h is now pointless)
Also fixed a minor issue where if you had two regions, you could also select the third region, even if you didnt have it installed.
Card region check
Split up edit_profile.c into save.c
Also added consoleClear()s for every state change on the top screen. Tried to outline bottom screen messages a bit better to account for less screen space.
Add restart functionality + Screen wiping
|
Will merge after getting confirmation that it works for #1 . UPDATE: Works. Will merge after cleaning up README.md/removing an unused (commented) code line from the source files. |
for beta testing.
noirscape
pushed a commit
that referenced
this pull request
Apr 12, 2018
* Using the enum properly. * Initial case of card and region checks Checks don't do anything yet aside from displaying warnings. * TWL/CTR card checking * Switch to using bools over ints * Added region autodetect, header guarding and moved structs to their own file. * Using a switch instead of the if blocks switch = more adaptable for later + this code was making me annoyed. * Prompt for multiple regions found * Removed pointless functions, fixed incorrect prompt and did general code reformatting. (main.h is now pointless) * More robust text prompts for later modifications * Adjust FS_MediaType in editprofile.c to actually be able to read from the gamecard * Added more gamecard changes to editprofile.c that I missed. Also fixed a minor issue where if you had two regions, you could also select the third region, even if you didnt have it installed. * Ternary operator for checking * Initial work on splitting up for save detection * Savedata checking in much the same manner as checking for dupe copies. * Added savedata readouts (not very well optimized) * Moved closing everything to its own function in save.c * Split up final parts * Print selection info to the bottom screen instead of the top screen. * Resolves an unbroken switch statement + removed a pointless parameter. * Added back functionality to the L button and fixed a minor print fail for save info * Clean out print statements from source files other than main.c Also added consoleClear()s for every state change on the top screen. Tried to outline bottom screen messages a bit better to account for less screen space. * Added new failure state to account for failures w/ the new screen clean function. * ohgodwhat that printf shouldve been called only once 😅 Also moved the window clean step _after_ the reset since it was messing with the main menu. * Handle an edge case where someone presses L on MAIN_SCREEN * Preventing fallthrough of FAILURE state * License headers added, removed Known Issues and thanked @Sonlen1414 for beta testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a lot of end-user changes, but a lot of rework under the hood.
End user changes:
Under the hood changes:
switch.