forked from openshift/installer
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM - Jefferson release 4.5 #108
Open
snaiksat
wants to merge
677
commits into
jefferson
Choose a base branch
from
jefferson-release-4.5
base: jefferson
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link currently points to the repo (and hence README), which doesn't have the essential information and is not really a guide that we are claiming it to be, here. Let's link directly to the getting started guide.
metal: Fix matchbox link in docs
Sets the Machine API to use the folder value if specified in the install-config. Otherwise defaults the folder value to the cluster id. Updates cloud provider config to use the cluster ID for default value, where it had been using the cluster name before. In the machine pool we use the absolute path for the default cluster ID, e.g.: /<datacenter>/vm/<clusterID> Although a relative path (that is, just specifying the folder name) seems to work for a top-level VM folder, I am using the absolute path to be consistent with the nested folder use case which requires an absolute path. The cloud provider config, on the other hand seems to prefer a relative path based on the documentation: https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/existing.html
…dates the import ova resource to create an absolute path, otherwise the folder would not be found if an existing nested folder was used.
This commit modifies vSphere destroy to allow for user-provided folders, which should not be deleted: - removes error when no tagged folder is found - skip folder destroy when no tagged folder is found - removes check to ensure VMs are in tagged folder when deleting VMs
Uses vCenter API to check if folder provided in the installconfig exists. This validation is part of the PlatformProvisionCheck asset so this validation will only be run before create cluster. Creating other assets should still succeed without access to the API.
Bug 1831366: upi/metal fix compact clusters after porting to terraform v0.12
baremetal: Clarify install config needs to be hand-written in the docs
…h reachable And it's not the guide we're talking about. :)
baremetal: Link directly to getting-started guide in the docs
Bug 1830995: Add ModifyTargetGroupAttributes and Describe* to MasterIamRole
baremetal: Clarify it's the matchbox instance that needs to be public reachable
Signed-off-by: Roy Golan <[email protected]>
Signed-off-by: Roy Golan <[email protected]>
The vnic profile that all the VM shares can now be configurable through the platform and is part of the wizard, in case there are multiple for the selected network. ```yaml platform: ovirt: vnicProfileID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx ``` Signed-off-by: Roy Golan <[email protected]>
…z-1826100 Bug 1826100: vSphere allow users to specify existing folder
bug 1807111: terraform/exec: suppress the warnings from error to debug
Bug 1831760: Fix bootstrap certificate generation
Prior to this change, the documentation refers to working clusters with two workers. As of 4.5, two workers of 2vCPUs are not enough for a healthy cluster.
Bug 1814605: openstack: Require three workers
Bug 1816714: ovirt - add vnic profile id to platform
docs/user: add troubleshootingbootstrap to define the bootstrap log bundle
baremetal: Fix a small typo in cp cmdline in docs
baremetal: Fix broken link to example tfvars in docs
Also import the node bd and vrf dn from acc-provision tar gz (cherry picked from commit 848d510)
(cherry picked from commit dfe1018)
(cherry picked from commit b86b5fb)
(cherry picked from commit 3ea9cff)
(cherry picked from commit 6897f74)
Set defaults for the following fields in inventory.yaml file: node network interface to ens3 opflex network interface to ens4 opflex network subnet to 192.168.208.0/20 (cherry picked from commit 8b2a348)
…r {INFRA-ID}-primaryClusterNetwork (cherry picked from commit b7a2642)
(cherry picked from commit 1caa5c9)
(cherry picked from commit a806a61)
(cherry picked from commit 6ee19ea)
Add dns_ip under aci_cni in inventory file, however this is optional (cherry picked from commit 8cc0621)
(cherry picked from commit 45e7d39)
…on3 version (cherry picked from commit 78c7042)
Included by mistake (cherry picked from commit de637b2)
(cherry picked from commit 36c196f)
(cherry picked from commit dba1491)
(cherry picked from commit 5ef9b84)
(cherry picked from commit 9ace8dc)
(cherry picked from commit de07e9d)
(cherry picked from commit ec777b4)
…r-machineset-0.yaml before create ignition phase (cherry picked from commit a0444f6)
(cherry picked from commit 753b4a6)
Fixing minor typo {{ aci_cni['dns_ip'] }} to {{ item }}
1. Updated the updatee_ign.py with contents in network scripts as expected by the MCO 2. Removed MCO disable check files/yamls from the repository (cherry picked from commit 7826cfd)
1. Bootstrap can run and function properly on single node interface and bring up the master nodes 2. Second opflex interface is not needed for it. (cherry picked from commit 0eb11e2)
Backporting changes from jefferson Image to jefferson-release-4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.