feat: added predefined curves #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fully constrained `hash_to_curve` method fixed bug where `evaluate_linear_expression` was not working added `msm` method into `BigCurve`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added fully constrained
hash_to_curvemethodfixed bug where
evaluate_linear_expressionwas not workingadded
msmmethod intoBigCurveProblem*
Previously BigCurve did not provide parameters for predefined cures, requiring the user to derive them (including offset generators)
Summary*
This PR now adds a
hash_to_curvemethod that is used to create methods that derive offset generators and curve parameters directly in Noir.In addition, predefined parameters for the following curves are defined in the
curvesdirectory:Additional Context
PR Checklist*
cargo fmton default settings.