Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nargo): create a specific error variant for compilation #923

Merged
merged 1 commit into from
Feb 28, 2023
Merged

chore(nargo): create a specific error variant for compilation #923

merged 1 commit into from
Feb 28, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Addresses (partially) #729

Description

Summary of changes

We now pass a specific error type for issues during compilation up rather than immediately exiting.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench added this pull request to the merge queue Feb 28, 2023
Merged via the queue into master with commit 4a0145f Feb 28, 2023
@TomAFrench TomAFrench deleted the compilation-error branch February 28, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @jfecher