Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nargo preprocess command #912

Merged
merged 5 commits into from
Mar 13, 2023
Merged

feat: add nargo preprocess command #912

merged 5 commits into from
Mar 13, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 24, 2023

Related issue(s)

Extends work done on #873 to cover nargo compile.

Description

Summary of changes

This PR adds the nargo preprocess command which accepts an ACIR file and generates proving and verification keys from it.

The motivation behind this is to decouple compilation and preprocessing, e.g. after compiling a noir program to a CompiledProgram we can initially generate a set of keys to prove against barretenberg however we may want to start generating proofs against gnark in future. Using nargo preprocess you could prove against the exact same CompiledProgram as you were before.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

chore: silence `nargo compile` output

fix: display `nargo prove` doc comment in help
@TomAFrench TomAFrench linked an issue Mar 1, 2023 that may be closed by this pull request
@TomAFrench TomAFrench marked this pull request as ready for review March 6, 2023 17:37
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench added this pull request to the merge queue Mar 13, 2023
@kevaundray
Copy link
Contributor

PR looks good -- going to remove this from the queue and release 0.3

@kevaundray kevaundray removed this pull request from the merge queue due to a manual request Mar 13, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Mar 13, 2023
Merged via the queue into master with commit 8922ceb Mar 13, 2023
@TomAFrench TomAFrench deleted the preprocess-command branch March 13, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preprocessing capabilities
4 participants