-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create a consolidated options struct for Driver
#908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Feb 24, 2023
hmm, looks like the way I've done it requires all the options to be written before the command, i.e. |
d8ad56b
to
09085c3
Compare
a5a32c7
to
4b8f03a
Compare
jfecher
reviewed
Feb 28, 2023
jfecher
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
We're currently passing a set of boolean flags into
Driver
(and then on toEvaluator
) for various compiler options. This causes a breaking change for these crates whenever we add or remove one of these flags.This PR adds a
CompileOptions
struct which defines all of the options which may be passed to the compiler. It'snon-exhaustive
so we can modify this later without causing breaking changes.This struct can then be built using theCompileOptionsBuilder
which allows users to override various options while otherwise using the default compiler settings.Dependency additions / changes
I've added a dependency onderive_builder
to derive a builder struct forCompileOptions
.Test additions / changes
Checklist
cargo fmt
with default settings.Additional context