Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Workaround the merge_group event not working #796

Merged
merged 3 commits into from
Feb 10, 2023
Merged

chore(ci): Workaround the merge_group event not working #796

merged 3 commits into from
Feb 10, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 9, 2023

Related issue(s)

Resolves #

Description

After landing the fix for MQs in #790, it still didn't work so I looked and found that it isn't working for anymore. Ref community/community#46757 (comment)

The suggestion was to use push and scope it to the branches MQ creates.

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

jfecher
jfecher previously approved these changes Feb 9, 2023
View reviewed changes
@phated phated added this pull request to the merge queue Feb 9, 2023
@phated phated removed this pull request from the merge queue due to a manual request Feb 9, 2023
@phated
Copy link
Contributor Author

phated commented Feb 10, 2023

Merge queue caught my mistake 😅

@kevaundray kevaundray enabled auto-merge February 10, 2023 10:30
auto-merge was automatically disabled February 10, 2023 11:05

Merge queue setting changed

@kevaundray kevaundray merged commit df5be8d into master Feb 10, 2023
@kevaundray kevaundray deleted the phated/mq-workaround branch February 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@jfecher jfecher jfecher left review comments

@kobyhallx kobyhallx Awaiting requested review from kobyhallx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phated @jfecher @kevaundray