Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from aztec-packages #6861

Closed
wants to merge 6 commits into from
Closed

feat: Sync from aztec-packages #6861

wants to merge 6 commits into from

Conversation

AztecBot
Copy link
Collaborator

Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
fix: remove table shifts (AztecProtocol/aztec-packages#10814)
chore(avm): radix opcode - remove immediates (AztecProtocol/aztec-packages#10696)
feat: PXE browser proving (AztecProtocol/aztec-packages#10704)
END_COMMIT_OVERRIDE

AztecBot and others added 5 commits December 18, 2024 18:49
@AztecBot
chore: apply sync fixes
ae2120f
@TomAFrench
.
3bda279
@TomAFrench
Merge branch 'master' into aztec-packages
fbff386 
* master:
  fix: detect cycles in globals (#6859)
  chore(ci): Execution time report (#6827)
  chore(ci): Add non determinism check and fixes (#6847)
  chore(docs): updating the solidity contract how-to guide (#6804)
  fix: double alias in path (#6855)
  feat: configurable external check failures (#6810)
  chore: move constant creation out of loop (#6836)
  fix: implement `as_field` and `from_field` in the interpreter (#6829)
  chore: Use Vec for callstacks (#6821)
  feat: replace `eval_global_as_array_length` with type/interpreter evaluation (#6469)
  chore: refactor `DataFlowGraph.insert_instruction_and_results` (#6823)
  chore(docs): updating noirjs tutorial for 1.0.0 (#6792)
@TomAFrench
.
6fa185f
@TomAFrench
.
f8a714e
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Changes to Brillig bytecode sizes

Generated at commit: fc0c2b06fda7f0fddf31a5853bc9ed2540ce997c, compared to commit: 021d62cfb71702603cc58e08a21eb3655a0c4a9d

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
to_bytes_integration +4 ❌ +4.55%
simple_radix +2 ❌ +2.70%
array_len +2 ❌ +2.08%
to_le_bytes +2 ❌ +1.64%
Full diff report 👇
Program Brillig opcodes (+/-) %
to_bytes_integration 92 (+4) +4.55%
simple_radix 76 (+2) +2.70%
array_len 98 (+2) +2.08%
to_le_bytes 124 (+2) +1.64%
to_bytes_consistent 137 (+2) +1.48%
hash_to_field 141 (+2) +1.44%
sha256_brillig_performance_regression 1,680 (+18) +1.08%
to_be_bytes 214 (+2) +0.94%
sha256_var_witness_const_regression 1,314 (+6) +0.46%
sha256 2,418 (+10) +0.42%
ram_blowup_regression 973 (+4) +0.41%
keccak256 2,205 (+8) +0.36%
sha256_var_size_regression 1,732 (+6) +0.35%
7_function 581 (+2) +0.35%
6 1,195 (+4) +0.34%
conditional_regression_short_circuit 1,268 (+4) +0.32%
brillig_cow_regression 2,173 (+6) +0.28%
regression_4449 753 (+2) +0.27%
merkle_insert 767 (+2) +0.26%
sha256_var_padding_regression 5,141 (+12) +0.23%
array_dynamic_nested_blackbox_input 903 (+2) +0.22%
ecdsa_secp256k1 910 (+2) +0.22%
simple_shield 910 (+2) +0.22%
sha256_regression 6,934 (+14) +0.20%
array_dynamic_blackbox_input 1,034 (+2) +0.19%
conditional_1 1,190 (+2) +0.17%
u128 2,761 (+4) +0.15%
sha2_byte 2,771 (+4) +0.14%
slices 2,188 (+2) +0.09%
bigint 2,197 (+2) +0.09%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Changes to number of Brillig opcodes executed

Generated at commit: fc0c2b06fda7f0fddf31a5853bc9ed2540ce997c, compared to commit: 021d62cfb71702603cc58e08a21eb3655a0c4a9d

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
simple_radix +2 ❌ +2.90%
array_len +2 ❌ +1.07%
verify_honk_proof -28 ✅ -0.66%
double_verify_honk_proof -56 ✅ -0.75%
Full diff report 👇
Program Brillig opcodes (+/-) %
simple_radix 71 (+2) +2.90%
array_len 189 (+2) +1.07%
regression_4449 201,977 (+1,120) +0.56%
sha256_var_witness_const_regression 7,234 (+34) +0.47%
sha256 15,062 (+66) +0.44%
6 7,482 (+32) +0.43%
conditional_regression_short_circuit 7,560 (+32) +0.43%
array_dynamic_nested_blackbox_input 4,566 (+16) +0.35%
conditional_1 5,733 (+16) +0.28%
to_bytes_consistent 756 (+2) +0.27%
ecdsa_secp256k1 6,805 (+16) +0.24%
hash_to_field 910 (+2) +0.22%
sha256_var_size_regression 16,411 (+34) +0.21%
to_bytes_integration 2,069 (+4) +0.19%
array_dynamic_blackbox_input 18,241 (+32) +0.18%
to_le_bytes 1,154 (+2) +0.17%
sha256_brillig_performance_regression 23,226 (+32) +0.14%
keccak256 34,809 (+32) +0.09%
sha256_regression 118,805 (+98) +0.08%
to_be_bytes 2,454 (+2) +0.08%
7_function 2,539 (+2) +0.08%
simple_shield 2,873 (+2) +0.07%
brillig_cow_regression 519,440 (+354) +0.07%
ram_blowup_regression 779,178 (+528) +0.07%
sha2_byte 47,341 (+32) +0.07%
slices 3,367 (+2) +0.06%
merkle_insert 3,771 (+2) +0.05%
sha256_var_padding_regression 222,312 (+96) +0.04%
u128 24,966 (+4) +0.02%
verify_honk_proof 4,188 (-28) -0.66%
double_verify_honk_proof 7,419 (-56) -0.75%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Peak Memory Sample

Program Peak Memory
keccak256 78.15M
workspace 122.62M
regression_4709 423.26M
ram_blowup_regression 1.58G
private-kernel-tail 206.71M
private-kernel-reset 720.29M
private-kernel-inner 291.91M
parity-root 171.71M

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Execution Sample

Program Execution Time %
sha256_regression 0m0.603s -3%
regression_4709 0m0.374s -4%
ram_blowup_regression 0m4.428s 1%
rollup-base-public 0m28.527s 2%
rollup-base-private 0m26.467s 2%
private-kernel-tail 0m0.721s 0%
private-kernel-reset 0m1.478s 0%
private-kernel-inner 0m0.944s -2%
parity-root 0m0.516s -3%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Compilation Sample

Program Compilation Time %
sha256_regression 0m1.395s -1%
regression_4709 0m0.797s -7%
ram_blowup_regression 0m14.697s -3%
rollup-base-public 3m30.546s -2%
rollup-base-private 3m12.538s 5%
private-kernel-tail 0m1.165s 0%
private-kernel-reset 0m7.792s 1%
private-kernel-inner 0m2.660s 7%
parity-root 0m1.177s 25%
noir-contracts 2m38.941s -2%

@TomAFrench TomAFrench closed this Jan 3, 2025
@TomAFrench TomAFrench deleted the aztec-packages branch January 3, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AztecBot @TomAFrench