You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up for #6857
Fixes the Wasm compilation in #6849
Summary*
Changes nargo::ops::test::run_test to take a generic function to create a ForeignCallExecutor, rather than a URL which it used for now to create a HTTP client, which would not compile to wasm, clashing with the goals of #6835
Refactored nargo to make it possible to import the test features without the rpc stuff. Changed the feature flags to only disable the DefaultForeignCallExecutor for Wasm.
Additional Context
Documentation*
Check one:
No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.
PR Checklist*
I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Follow up for #6857
Fixes the Wasm compilation in #6849
Summary*
Changes
nargo::ops::test::run_test
to take a generic function to create aForeignCallExecutor
, rather than a URL which it used for now to create a HTTP client, which would not compile to wasm, clashing with the goals of #6835Refactored
nargo
to make it possible to import thetest
features without therpc
stuff. Changed the feature flags to only disable theDefaultForeignCallExecutor
for Wasm.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.