Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not print entire functions when running debug trace #6814

Merged
merged 7 commits into from
Dec 13, 2024
Merged

chore: Do not print entire functions when running debug trace #6814

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fdc8ca2
do not print entire functions when runninga debug trace
vezenovm Dec 13, 2024
c1869bc
Update compiler/noirc_evaluator/src/ssa/checks/check_for_underconstra…
vezenovm Dec 13, 2024
572f72e
switch tainted Brillig to number of tainted calls
vezenovm Dec 13, 2024
2e23ad0
Merge remote-tracking branch 'origin/mv/smaller-trace-do-not-print-fu…
vezenovm Dec 13, 2024
577483c
delete another common trace
vezenovm Dec 13, 2024
2ccdb17
switch to num warnings not printing them all
vezenovm Dec 13, 2024
286b942
fmt
vezenovm Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ impl DependencyContext {
function: &Function,
all_functions: &BTreeMap<FunctionId, Function>,
) {
trace!("processing instructions of block {} of function {}", block, function);
trace!("processing instructions of block {} of function {}", block, function.id());

for instruction in function.dfg[block].instructions() {
let mut arguments = Vec::new();
Expand Down Expand Up @@ -319,11 +319,7 @@ impl DependencyContext {
Value::Function(callee) => match all_functions[&callee].runtime() {
RuntimeType::Brillig(_) => {
// Record arguments/results for each Brillig call for the check
trace!(
"Brillig function {} called at {}",
all_functions[&callee],
instruction
);
trace!("Brillig function {} called at {}", callee, instruction);
self.tainted.insert(
*instruction,
BrilligTaintedIds::new(&arguments, &results),
Expand Down Expand Up @@ -376,7 +372,7 @@ impl DependencyContext {
}
}

trace!("resulting Brillig involved values: {:?}", self.tainted);
trace!("Number tainted Brillig calls: {}", self.tainted.len());
}

/// Every Brillig call not properly constrained should remain in the tainted set
Expand Down
Loading