-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove Type
from Value
, and remove ctrl_typevars
#6771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
force-pushed
the
jf/no-value-types
branch
from
December 11, 2024 17:17
9ce361d
to
1691cf0
Compare
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Peak Memory Sample
|
Compilation Sample
|
5 tasks
5 tasks
Surprised this seems to improve compilation time for some programs. I'm just going to close this PR though and include this as part of the larger change to remove ValueIds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Summary*
Another step towards removing
ValueId
.Removes
Type
from theValue
enum to make Values copyable by moving types to be stored in Instructions when they weren't before. This means every instruction knows its result type(s) andctrl_typevars
are never neededUnlike #6769, this PR is a draft because I need to check performance - without the larger change to use a Value enum instead of ValueIds, this PR may result in worse performance alone.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.