Code

feat: --pedantic-solving flag#6716

Code

Merged

TomAFrench merged 51 commits intomasternoir-lang/noir:masterfrom michaeljklein/pedantic-flagnoir-lang/noir:michaeljklein/pedantic-flagCopy head branch name to clipboardJan 7, 2025

+879-300

Commits

Commits on Dec 4, 2024

• test input sizes and predicate values with --pedantic_solving flag, add method to check for valid bigint modulus, add error for predicate > 1, add cli option for pedantic solving

  michaeljklein

  committed
  b5ee668

  Copy full SHA for b5ee668

Commits on Dec 5, 2024

• add pedantic_solving parameter wherever needed, default to true when testing or constant-folding, add tests for pedantic_solving, test to ensure allowed bingint moduli are prime

  michaeljklein

  committed
  f65a0b0

  Copy full SHA for f65a0b0

Commits on Dec 6, 2024

• Update acvm-repo/blackbox_solver/src/bigint.rs

  Show description for d3e7bc5
  

  michaeljklein

  and

  aakoshh

  authored
  d3e7bc5

  Copy full SHA for d3e7bc5

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  d0b877f

  Copy full SHA for d0b877f

• remove default from structs that require the pedantic_solving parameter, store pedantic_solving in the bigint and blackbox solver structs, use pedantic_solving for tests

  michaeljklein

  committed
  b83d6b5

  Copy full SHA for b83d6b5

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  9f1d8c1

  Copy full SHA for 9f1d8c1

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  46b75fb

  Copy full SHA for 46b75fb

Commits on Dec 9, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  1e3e3cb

  Copy full SHA for 1e3e3cb

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  0833b11

  Copy full SHA for 0833b11

• wip moving 'pedantic_solving'

  michaeljklein

  committed
  b314b21

  Copy full SHA for b314b21

Commits on Dec 10, 2024

• wip debugging: use StubbedBlackBoxSolver::default to enable pedantic_solving, check grumpkin_integer and whether points are infinite for ec add and multi_scalar_mul

  michaeljklein

  committed
  4b0df94

  Copy full SHA for 4b0df94

Commits on Dec 11, 2024

• wip debugging, use 'point == ..Affine::zero()' to check for infinity, check that bool's are valid

  michaeljklein

  committed
  5fe6eaa

  Copy full SHA for 5fe6eaa

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  85d0e50

  Copy full SHA for 85d0e50

• fix typo, update smoke test to add two different points, cargo clippy/fmt

  michaeljklein

  committed
  a895f64

  Copy full SHA for a895f64

• Update acvm-repo/blackbox_solver/src/bigint.rs

  Show description for 3b42dd9
  

  michaeljklein

  and

  aakoshh

  authored
  3b42dd9

  Copy full SHA for 3b42dd9

• Update acvm-repo/acvm/src/pwg/mod.rs

  Show description for f7ee3b8
  

  michaeljklein

  and

  TomAFrench

  authored
  f7ee3b8

  Copy full SHA for f7ee3b8

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  7c7766a

  Copy full SHA for 7c7766a

• fix small refactor and use single constant for pedantic_solving in memory_op tests

  michaeljklein

  committed
  8796f15

  Copy full SHA for 8796f15

• updating lsp usage of solvers, cargo clippy/fmt

  michaeljklein

  committed
  3e89c31

  Copy full SHA for 3e89c31

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  1ad3ba1

  Copy full SHA for 1ad3ba1

• update test error message

  michaeljklein

  committed
  7b5d66e

  Copy full SHA for 7b5d66e

Commits on Dec 12, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  TomAFrench

  authored
  588e4a0

  Copy full SHA for 588e4a0

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  813b8a5

  Copy full SHA for 813b8a5

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  3bbd894

  Copy full SHA for 3bbd894

• cargo fmt

  michaeljklein

  committed
  fd6085b

  Copy full SHA for fd6085b

Commits on Dec 14, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  d22a1bd

  Copy full SHA for d22a1bd

Commits on Dec 16, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  4ed1e24

  Copy full SHA for 4ed1e24

• Update acvm-repo/bn254_blackbox_solver/src/embedded_curve_ops.rs

  Show description for a1f824b
  

  michaeljklein

  and

  TomAFrench

  authored
  a1f824b

  Copy full SHA for a1f824b

• use '--pedantic-solving' in CI and example programs

  michaeljklein

  committed
  8ea09ba

  Copy full SHA for 8ea09ba

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  b67ab01

  Copy full SHA for b67ab01

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  e8e27db

  Copy full SHA for e8e27db

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  f5e00e0

  Copy full SHA for f5e00e0

Commits on Dec 17, 2024

• revert nargo->cargo testing change

  michaeljklein

  committed
  6146477

  Copy full SHA for 6146477

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  6b919bb

  Copy full SHA for 6b919bb

• Update examples/prove_and_verify/prove_and_verify.sh

  TomAFrench

  authored
  0556d1c

  Copy full SHA for 0556d1c

Commits on Dec 19, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  TomAFrench

  authored
  b9af2d1

  Copy full SHA for b9af2d1

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  c4d8c87

  Copy full SHA for c4d8c87

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  c30af47

  Copy full SHA for c30af47

Commits on Dec 20, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  c12ff56

  Copy full SHA for c12ff56

Commits on Dec 21, 2024

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  91c9440

  Copy full SHA for 91c9440

Commits on Jan 3, 2025

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  a447530

  Copy full SHA for a447530

• fixup after merge

  michaeljklein

  committed
  905f4f2

  Copy full SHA for 905f4f2

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  fed6e7c

  Copy full SHA for fed6e7c

Commits on Jan 5, 2025

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  6186750

  Copy full SHA for 6186750

Commits on Jan 6, 2025

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  55de7d6

  Copy full SHA for 55de7d6

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  b219538

  Copy full SHA for b219538

• allow clippy::too_many_arguments when constructing Elaborator

  michaeljklein

  committed
  56362d4

  Copy full SHA for 56362d4

Commits on Jan 7, 2025

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  a7820ad

  Copy full SHA for a7820ad

• cargo fmt

  michaeljklein

  committed
  5adbaae

  Copy full SHA for 5adbaae

• fix after merge

  michaeljklein

  committed
  75f912e

  Copy full SHA for 75f912e

• Merge branch 'master' into michaeljklein/pedantic-flag

  michaeljklein

  authored
  b013d23

  Copy full SHA for b013d23